gengliangwang commented on code in PR #37460:
URL: https://github.com/apache/spark/pull/37460#discussion_r942770985
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryEval.scala:
##########
@@ -91,7 +91,17 @@ case class TryCast(child: Expression, toType: DataType,
timeZoneId: Option[Strin
(!Cast.needsTimeZone(child.dataType, toType) || timeZoneId.isDefined)
override lazy val replacement = {
- TryEval(Cast(child, toType, timeZoneId = timeZoneId, ansiEnabled = true))
+ if (equivalentToNonAnsiCast) {
+ Cast(child, toType, timeZoneId = timeZoneId, ansiEnabled = false)
+ } else {
+ TryEval(Cast(child, toType, timeZoneId = timeZoneId, ansiEnabled = true))
+ }
+ }
+
+ private def equivalentToNonAnsiCast: Boolean = {
Review Comment:
> Maybe we could keep the TryEval in place but still set ansiEnabled = false
when we know that the Cast itself is equivalent? This would still give us
performance benefits since we still avoid the cost of throwing and catching
Cast exceptions.
That's a really good point. Thank you @JoshRosen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
