Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/5788#issuecomment-102526614
LGTM aside from the SparkConf changes, which I think are unnecessary.
I also agree with @jerryshao's comment; any change, be it a bug fix or
feature, should always be made on master first, and later backported if
desired. The only exception is when the change is not needed on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
