sadikovi commented on PR #37293: URL: https://github.com/apache/spark/pull/37293#issuecomment-1212570654
Yes, I can open a follow-up PR to make the code slightly more robust to internal implementation changes in Parquet-Mr. ----------- @dongjoon-hyun Respectfully, I don't quite understand what you meant in your post and what was concerning in the discussion. I would appreciate it if you could elaborate but I also tried to clarify some of discussion points below. I was pointing out the code that was relying on the internal implementation details of a library (see [Hyrum's law](https://www.hyrumslaw.com/)) instead of using public API of such library and was merely suggesting to minimise the dependency. I was not considering the revert of this PR. In fact, I posted my suggestions and specifically advocated for not reverting the PR as it brings performance improvements in my comment. The sentence you mentioned was a reply to the author's comment stating it had something to do with the current, existing, codebase (instead, in my opinion, it is an example of Hyrum's law with regard to the code change relying on Parquet-Mr library and using internal interfaces). Also, I was expressing my opinion in that sentence as I wrote "I think it ...". I also agreed with the author's response with the 👍 reaction. It appears you might have taken parts of the sentence out of context to accuse me of being disrespectful to or aggressive towards the author in some way which may be a subject of defamation. FYI, this PR was reviewed and merged by one person without bringing additional committers or reviewers before the merge. I discovered this PR by reviewing commits in master branch. I don't have any downstream forks. My statement regarding users of Apache Spark was general and I had provided possible fixes/improvements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
