dongjoon-hyun commented on code in PR #36433:
URL: https://github.com/apache/spark/pull/36433#discussion_r944102080
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsWatchSnapshotSource.scala:
##########
@@ -38,19 +40,23 @@ import org.apache.spark.util.Utils
@DeveloperApi
class ExecutorPodsWatchSnapshotSource(
snapshotsStore: ExecutorPodsSnapshotsStore,
- kubernetesClient: KubernetesClient) extends Logging {
+ kubernetesClient: KubernetesClient,
+ conf: SparkConf) extends Logging {
Review Comment:
Oh, this is a developer API as `Stable` level. Could you make a separate
constructor for this new feature?
I believe we should keep the existing 2-parameter constructer for backward
compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
