GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/6200
[SPARK-7655][Core][SQL] Remove
'scala.concurrent.ExecutionContext.Implicits.global' in 'ask' and
'BroadcastHashJoin'
Because both `AkkaRpcEndpointRef.ask` and `BroadcastHashJoin` uses
`scala.concurrent.ExecutionContext.Implicits.global`. However, because the
tasks in `BroadcastHashJoin` are usually long-running tasks, which will occupy
all threads in `global`. Then `ask` cannot get a chance to process the replies.
For `ask`, actually the tasks are very simple, so we can use
`MoreExecutors.sameThreadExecutor()`. For `BroadcastHashJoin`, it's better to
use `ThreadUtils.newDaemonCachedThreadPool`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-7655-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/6200.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6200
----
commit 08ad0ee60140b9fe662fb0a216bbeced40d0fe81
Author: zsxwing <[email protected]>
Date: 2015-05-15T21:27:14Z
Remove 'scala.concurrent.ExecutionContext.Implicits.global' in 'ask' and
'BroadcastHashJoin'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
