gengliangwang commented on code in PR #37486:
URL: https://github.com/apache/spark/pull/37486#discussion_r944165517
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TryCastSuite.scala:
##########
@@ -79,3 +99,14 @@ class TryCastSuite extends SparkFunSuite {
assert(!c4.resolved)
}
}
+
+class TryCastThrowExceptionSuite extends SparkFunSuite with
ExpressionEvalHelper {
+ // The method checkExceptionInExpression is overridedn in TryCastSuite, so
here we have a
+ // new test suite for testing exceptions from the child of `try_cast()`.
+ test("TryCast should not catch the exception from it's child") {
Review Comment:
Please read my comment above.
The method checkExceptionInExpression is overridden in TryCastSuite for
testing all the cases should return nulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
