Resol1992 commented on code in PR #37404:
URL: https://github.com/apache/spark/pull/37404#discussion_r944632762
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileStatusCache.scala:
##########
@@ -36,6 +37,8 @@ import org.apache.spark.util.SizeEstimator
object FileStatusCache {
private var sharedCache: SharedInMemoryCache = _
Review Comment:
@cloud-fan In fact, if we set the value of
`spark.sql.hive.filesourcePartitionFileCacheSize` about the same as or even
larger than the value of `spark.driver.memory`, it may cause OOM.
Even if OOM doesn't occur, we should still clean these `FileStatus` objects
in the `Cache` when we close a sparkSession, because they are useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]