gengliangwang commented on code in PR #37430:
URL: https://github.com/apache/spark/pull/37430#discussion_r944804283
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -863,25 +863,17 @@ class InsertSuite extends DataSourceTest with
SharedSparkSession {
}
test("Allow user to insert specified columns into insertable view") {
- withSQLConf(SQLConf.USE_NULLS_FOR_MISSING_DEFAULT_COLUMN_VALUES.key ->
"true") {
- sql("INSERT OVERWRITE TABLE jsonTable SELECT a FROM jt")
- checkAnswer(
- sql("SELECT a, b FROM jsonTable"),
- (1 to 10).map(i => Row(i, null))
- )
-
- sql("INSERT OVERWRITE TABLE jsonTable(a) SELECT a FROM jt")
- checkAnswer(
- sql("SELECT a, b FROM jsonTable"),
- (1 to 10).map(i => Row(i, null))
- )
+ sql("INSERT OVERWRITE TABLE jsonTable(a) SELECT a FROM jt")
+ checkAnswer(
+ sql("SELECT a, b FROM jsonTable"),
+ (1 to 10).map(i => Row(i, null))
Review Comment:
ok, so in Spark 3.3:
```
> create table foo(a int, b int);
> insert into foo (a) values (1);
Error in query: `default`.`foo` requires that the data to be inserted have
the same number of columns as the target table: target table has 2 column(s)
but the inserted data has 1 column(s), including 0 partition column(s) having
constant value(s).
```
Seems the column default project introduces a breaking change..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
