LuciferYang commented on code in PR #37487:
URL: https://github.com/apache/spark/pull/37487#discussion_r945074317
##########
core/src/main/scala/org/apache/spark/TestUtils.scala:
##########
@@ -281,9 +281,13 @@ private[spark] object TestUtils {
attempt.isSuccess && attempt.get == 0
}
- def isPythonVersionAtLeast38(): Boolean = {
+ def isPythonVersionAtLeast37(): Boolean = isPythonVersionAtLeast(3, 7, 0)
+
+ def isPythonVersionAtLeast38(): Boolean = isPythonVersionAtLeast(3, 8, 0)
Review Comment:
@HyukjinKwon just have a question but not related to this pr
https://github.com/apache/spark/blob/1a1e4938f97ecedbb99a440df27d365439a9a621/sql/core/src/test/scala/org/apache/spark/sql/IntegratedUDFTestUtils.scala#L108
Should the above code call `TestUtils.isPythonVersionAtLeast37()` instead?
like
```
private lazy val isPythonAvailable: Boolean =
TestUtils.isPythonVersionAtLeast37()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
