viirya commented on code in PR #37490:
URL: https://github.com/apache/spark/pull/37490#discussion_r945320272
##########
python/pyspark/sql/catalog.py:
##########
@@ -613,47 +778,76 @@ def createTable(
df = self._jcatalog.createTable(tableName, source, scala_datatype,
description, options)
return DataFrame(df, self._sparkSession)
- def dropTempView(self, viewName: str) -> None:
+ def dropTempView(self, viewName: str) -> bool:
"""Drops the local temporary view with the given view name in the
catalog.
If the view has been cached before, then it will also be uncached.
Returns true if this view is dropped successfully, false otherwise.
.. versionadded:: 2.0.0
- Notes
- -----
- The return type of this method was None in Spark 2.0, but changed to
Boolean
- in Spark 2.1.
+ Parameters
+ ----------
+ viewName : str
+ name of the temporary view to drop.
+
+ Returns
+ -------
+ bool
+ If the temporary view was successfully drooped or not.
+
+ .. versionadded:: 2.1.0
+ The return type of this method was ``None`` in Spark 2.0, but
changed to ``bool``
+ in Spark 2.1.
Examples
--------
>>> spark.createDataFrame([(1, 1)]).createTempView("my_table")
- >>> spark.table("my_table").collect()
- [Row(_1=1, _2=1)]
+
+ Droppping the temporary view.
+
>>> spark.catalog.dropTempView("my_table")
True
- >>> spark.table("my_table") # doctest: +IGNORE_EXCEPTION_DETAIL
+
+ Throw an exception if the temporary view does not exists.s
+
+ >>> spark.table("my_table")
Traceback (most recent call last):
...
AnalysisException: ...
"""
return self._jcatalog.dropTempView(viewName)
- def dropGlobalTempView(self, viewName: str) -> None:
+ def dropGlobalTempView(self, viewName: str) -> bool:
"""Drops the global temporary view with the given view name in the
catalog.
- If the view has been cached before, then it will also be uncached.
- Returns true if this view is dropped successfully, false otherwise.
.. versionadded:: 2.1.0
+ Parameters
+ ----------
+ viewName : str
+ name of the global view to drop.
+
+ Returns
+ -------
+ bool
+ If the global view was successfully drooped or not.
+
+ Notes
+ -----
+ If the view has been cached before, then it will also be uncached.
+
Examples
--------
>>> spark.createDataFrame([(1, 1)]).createGlobalTempView("my_table")
- >>> spark.table("global_temp.my_table").collect()
- [Row(_1=1, _2=1)]
+
+ Droppping the global view.
+
>>> spark.catalog.dropGlobalTempView("my_table")
True
- >>> spark.table("global_temp.my_table") # doctest:
+IGNORE_EXCEPTION_DETAIL
+
+ Throw an exception if the global view does not exists.s
Review Comment:
```suggestion
Throw an exception if the global view does not exists.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
