sumeetgajjar commented on code in PR #37505:
URL: https://github.com/apache/spark/pull/37505#discussion_r946209022
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala:
##########
@@ -37,7 +37,8 @@ case class BatchScanExec(
@transient scan: Scan,
runtimeFilters: Seq[Expression],
keyGroupedPartitioning: Option[Seq[Expression]] = None,
- ordering: Option[Seq[SortOrder]] = None) extends DataSourceV2ScanExecBase {
+ ordering: Option[Seq[SortOrder]] = None,
+ table: Option[String] = None) extends DataSourceV2ScanExecBase {
Review Comment:
> BTW, since `Scan` can only be created from `Table`, when this new
parameter can be `None`?
It is `None` while instantiating `BatchScanExec` in the following two test
cases in `SQLAppStatusListenerSuite`
- "SPARK-34338: Report metrics from Datasource v2 scan"
https://github.com/apache/spark/blob/1103343e71fbcb478fa41941c87d2c28b0c09281/sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala#L843
- "SPARK-39635: Report driver metrics from Datasource v2 scan"
https://github.com/apache/spark/blob/1103343e71fbcb478fa41941c87d2c28b0c09281/sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala#L881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
