bersprockets commented on code in PR #37513:
URL: https://github.com/apache/spark/pull/37513#discussion_r946227016
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -3055,17 +3055,25 @@ object Sequence {
val startMicros: Long = toMicros(num.toLong(start), scale)
val stopMicros: Long = toMicros(num.toLong(stop), scale)
- val maxEstimatedArrayLength =
+ val estimatedArrayLength =
getSequenceLength(startMicros, stopMicros, input3,
intervalStepInMicros)
val stepSign = if (intervalStepInMicros > 0) +1 else -1
val exclusiveItem = stopMicros + stepSign
- val arr = new Array[T](maxEstimatedArrayLength)
+ var arr = new Array[T](estimatedArrayLength)
var t = startMicros
var i = 0
while (t < exclusiveItem ^ stepSign < 0) {
val result = fromMicros(t, scale)
+ // if we've underestimated the size of the array, due to crossing a
DST
+ // "spring forward" without a corresponding "fall back", make a copy
+ // that's larger by 1
+ if (i == arr.length) {
+ val newArr = new Array[T](estimatedArrayLength + 1)
Review Comment:
Actually, I can shorten this to `val arr = arr.padTo(...)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
