ivoson commented on code in PR #37268:
URL: https://github.com/apache/spark/pull/37268#discussion_r946254804
##########
core/src/main/scala/org/apache/spark/resource/ResourceProfileBuilder.scala:
##########
@@ -76,6 +79,17 @@ class ResourceProfileBuilder() {
this
}
+ /**
+ * Specify target resource profile type.
+ * @param isTaskResourceProfile will create a [[TaskResourceProfile]] if
true, otherwise a
+ * normal [[ResourceProfile]]
+ * @return This ResourceProfileBuilder
+ */
+ def taskOnly(isTaskResourceProfile: Boolean = true): this.type = {
Review Comment:
Hey @tgravescs , there are some difference here I think.
In this PR, we add a new `TaskResourceProfile`, which is limited to some
scenarios like dynamic allocation off and it will reuse executors. So that we
may want user to explicitly specify it's a `TaskResourceProfile` to avoid
misunderstanding.
With dynamic allocation enabled, user can still create a `ResourceProfile`
without specifying executor requirements, and request new executors for this rp.
Does this make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
