ryan-johnson-databricks opened a new pull request, #37531:
URL: https://github.com/apache/spark/pull/37531
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Clean up the semantics of spark task listeners. Today, if a task body
succeeds, but a completion listener fails, failure listeners are not called --
even tho the task has indeed failed at that point. The fix is to invoke failure
listeners if a completion listener fails, before running the remaining
completion listeners.
### Why are the changes needed?
Failure listeners are not reliably called today, if the task failure is
caused by a failed completion listener. This limits the utility of task
listeners, especially ones that could assist with task cleanup.
### Does this PR introduce _any_ user-facing change?
No changes to public methods, but failure listeners will now run when a
completion listener fails, where previously they did not.
### How was this patch tested?
New unit tests exercise various combinations of failed listeners, with a
task body that did (or did not) throw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
