wankunde opened a new pull request, #37533:
URL: https://github.com/apache/spark/pull/37533
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Bug fix for finalize shuffle stage slow. When we enable push based shuffle
and some merger external shuffle service nodes were lost, driver try to connect
those merger shuffle services and send finalize RPC one by one, each connection
creation will timeout after SPARK_NETWORK_IO_CONNECTIONCREATIONTIMEOUT_KEY
(120s by default). This will be very slow.
We will send these RPCs in shuffleMergeFinalizeScheduler thread pool and
handle the connection creation exception
### Why are the changes needed?
Send finalize RPCs will block the main thread due to creating connection to
some unreachable nodes.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Add UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
