IonutBoicuAms commented on code in PR #37228:
URL: https://github.com/apache/spark/pull/37228#discussion_r946560284
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java:
##########
@@ -324,6 +331,10 @@ public boolean nextBatch() throws IOException {
}
cv.assemble();
}
+ // If needed, compute row indexes within a file.
+ if (rowIndexGenerator != null) {
+ rowIndexGenerator.populateRowIndex(columnVectors, num);
Review Comment:
Was looking through the code and it seems like it happens after row group
skipping. Also, the tests in `ParquetRowIndexSuite` check that the rowIndex
column doesn't have any of the values from the skipped row groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
