cloud-fan commented on code in PR #37519:
URL: https://github.com/apache/spark/pull/37519#discussion_r947485574


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -86,6 +86,7 @@ abstract class Optimizer(catalogManager: CatalogManager)
         PushDownPredicates,
         PushDownLeftSemiAntiJoin,
         PushLeftSemiLeftAntiThroughJoin,
+        EliminateSorts,

Review Comment:
   this means we depend on the rule order, which violates the design goal of 
catalyst.
   
   Can we update the `EliminateSorts` to allow `LocalLimit` between Join and 
Sort?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to