seunggabi commented on PR #37478:
URL: https://github.com/apache/spark/pull/37478#issuecomment-1218000689
@srowen
yes. you're right.
`as-is` is works every case.
but, I suggested for flexible code.
worth is flexible code? <- it may be my own idea.
if this pr is closed, I'm OK!
please make a decision (destiny of this PR)
---
### as-is
```kotlin
b = when (v) {
is Long -> b.config(k, v)
is String -> b.config(k, v)
is Double -> b.config(k, v)
is Boolean -> b.config(k, v)
else -> b
}
```
### to-be
```kotlin
b = b.conf(it, map[it])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]