MaxGekk commented on code in PR #37520:
URL: https://github.com/apache/spark/pull/37520#discussion_r948755303
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerWithSparkContextSuite.scala:
##########
@@ -149,6 +149,64 @@ trait ThriftServerWithSparkContextSuite extends
SharedThriftServer {
}
}
}
+
+ test("formats of error messages") {
+ val sql = "select 1 / 0"
+ withCLIServiceClient() { client =>
+ val sessionHandle = client.openSession(user, "")
+ val confOverlay = new java.util.HashMap[java.lang.String,
java.lang.String]
+ val exec: String => OperationHandle =
client.executeStatement(sessionHandle, _, confOverlay)
+
+ exec(s"set ${SQLConf.ANSI_ENABLED.key}=true")
+ exec(s"set
${SQLConf.ERROR_MESSAGE_FORMAT.key}=${ErrorMessageFormat.PRETTY}")
+ val e1 = intercept[HiveSQLException](exec(sql))
+ // scalastyle:off line.size.limit
+ assert(e1.getMessage ===
+ """Error running query: [DIVIDE_BY_ZERO] Division by zero. Use
`try_divide` to tolerate divisor being 0 and return NULL instead. If necessary
set "spark.sql.ansi.enabled" to "false" to bypass this error.
+ |== SQL(line 1, position 8) ==
+ |select 1 / 0
+ | ^^^^^
+ |""".stripMargin)
+
+ exec(s"set
${SQLConf.ERROR_MESSAGE_FORMAT.key}=${ErrorMessageFormat.MINIMAL}")
+ val e2 = intercept[HiveSQLException](exec(sql))
+ assert(e2.getMessage ===
+ """Error running query: {
+ | "errorClass" : "DIVIDE_BY_ZERO",
+ | "sqlState" : "22012",
+ | "messageParameters" : {
+ | "config" : "\"spark.sql.ansi.enabled\""
+ | },
+ | "queryContext" : [ {
+ | "objectType" : "",
+ | "objectName" : "",
+ | "startIndex" : 8,
+ | "stopIndex" : 12,
+ | "fragment" : "1 / "
Review Comment:
Here is the JIRA for the issue:
https://issues.apache.org/jira/browse/SPARK-40136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
