dongjoon-hyun commented on PR #35663:
URL: https://github.com/apache/spark/pull/35663#issuecomment-1219932633
1. For the doc, you can proceed it in another PRs, but you should make them
first and mention them in your PR description as a link for the community
reviews. Otherwise, we cannot verify your contribution.
2. Yes, we are expecting something like the following.
```
--conf spark.kubernetes.driver.scheduler.name=yunikorn \
--conf
spark.kubernetes.driver.annotation.yunikorn.apache.org/app-id={{APP_ID}} \
--conf
spark.kubernetes.executor.annotation.yunikorn.apache.org/app-id={{APP_ID}} \
--conf
spark.kubernetes.driver.pod.featureSteps=org.apache.spark.deploy.k8s.features.YuniKornFeatureStep
\
--conf
spark.kubernetes.executor.pod.featureSteps=org.apache.spark.deploy.k8s.features.YuniKornFeatureStep
```
In short, Apache Spark community don't want to repeat the same logic like
SPARK-38383 in every custom scheduler implementations and their test codes.
It's only error-prone and misleading to have the same logic in many places. To
be safe and consistent across all custom scheduler backend, please respect
Apache Spark's feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
