[GitHub] [spark] wangyum commented on a diff in pull request #37562: [SPARK-40133][SQL][TESTS] Update excluded TPC-DS queries golden files

Thu, 18 Aug 2022 17:50:22 -0700 


wangyum commented on code in PR #37562:
URL: https://github.com/apache/spark/pull/37562#discussion_r949707627


##########
core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala:
##########
@@ -45,7 +45,6 @@ class SparkThrowableSuite extends SparkFunSuite {
         "core/testOnly *SparkThrowableSuite -- -t \"Error classes are 
correctly formatted\""
    }}}
    */
-  private val regenerateGoldenFiles: Boolean = 
System.getenv("SPARK_GENERATE_GOLDEN_FILES") == "1"

Review Comment:
   `TPCDSBase` needs this parameter:
   <img width="1353" alt="image" 
src="https://user-images.githubusercontent.com/5399861/185517872-92adabf2-bc12-488b-906f-b382e5c01d71.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to