dongjoon-hyun commented on code in PR #35886:
URL: https://github.com/apache/spark/pull/35886#discussion_r949715211
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala:
##########
@@ -381,4 +381,34 @@ object KubernetesUtils extends Logging {
}
}
}
+
+ /**
+ * This function builds the EnvVar objects for each key-value env.
Review Comment:
Also, in the function description, can we explicitly mention that we can use
an empty string value to define a key-only EnvVar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
