steveloughran commented on code in PR #37468:
URL: https://github.com/apache/spark/pull/37468#discussion_r950165502
##########
hadoop-cloud/src/hadoop-3/main/scala/org/apache/spark/internal/io/cloud/PathOutputCommitProtocol.scala:
##########
@@ -51,14 +51,7 @@ class PathOutputCommitProtocol(
jobId: String,
dest: String,
dynamicPartitionOverwrite: Boolean = false)
- extends HadoopMapReduceCommitProtocol(jobId, dest, false) with Serializable {
-
- if (dynamicPartitionOverwrite) {
- // until there's explicit extensions to the PathOutputCommitProtocols
- // to support the spark mechanism, it's left to the individual committer
- // choice to handle partitioning.
- throw new IOException(PathOutputCommitProtocol.UNSUPPORTED)
- }
+ extends HadoopMapReduceCommitProtocol(jobId, dest,
dynamicPartitionOverwrite) with Serializable {
Review Comment:
added an explanation of what now happens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
