Github user sun-rui commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6183#discussion_r30455447
  
    --- Diff: core/src/main/scala/org/apache/spark/api/r/SerDe.scala ---
    @@ -166,6 +166,24 @@ private[spark] object SerDe {
         }
       }
     
    +  def readEnv(in: DataInputStream): java.util.Map[Object, Object] = {
    --- End diff --
    
    I just want to keep readMap() for the case where in R side an environment 
in which all values are of same type, the value type is serialized once. It is 
optimized than readEnv(). But I am OK if you think we can update readMap() and 
remove readEnv() for now and do such optimization in the future if necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to