GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/6205
[SPARK-6980] [CORE] [WIP] Akka timeout exceptions indicate which conf
controls them (RPC Layer)
Latest changes after refactoring to the RPC layer. I rebased against trunk
to make sure to get any recent changes since it had been a while. I wasn't
crazy about the name `ConfigureTimeout` and `RpcTimeout` seemed to fit better,
but I'm open to suggestions!
I ran most of the tests and they pass, but others would get stuck with
"WARN TaskSchedulerImpl: Initial job has not accepted any resources". I think
its just my machine, so I'd though I would push what I have anyway.
Still left to do:
* I only added a couple unit tests so far, there are probably some more
cases to test
* Make sure all uses require a `RpcTimeout`
* Right now, both the `ask` and `Await.result` use the same timeout, should
we differentiate between these in the TimeoutException message?
* I wrapped `Await.result` in `RpcTimeout`, should we also wrap
`Await.ready`?
* Proper scoping of classes and methods
@hardmettle, feel free to help out with any of these!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BryanCutler/spark configTimeout-6980
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/6205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6205
----
commit 97523e05c97dc0ea58465aad748357d8f2fc14f9
Author: Bryan Cutler <[email protected]>
Date: 2015-05-15T08:32:55Z
[SPARK-6980] Akka ask timeout description refactored to RPC layer
commit 78a2c0a0a94dbbea9c58498669318e28c0fddf3c
Author: Bryan Cutler <[email protected]>
Date: 2015-05-16T00:02:11Z
[SPARK-6980] Using RpcTimeout.awaitResult for future in AppClient now
commit 5b59a449dc2535242e218ce2b8b316beae410564
Author: Bryan Cutler <[email protected]>
Date: 2015-05-16T00:03:23Z
[SPARK-6980] Added some RpcTimeout unit tests
commit 49f9f04e13c25d86f7f058ff757c098cc9e60ebb
Author: Bryan Cutler <[email protected]>
Date: 2015-05-16T00:03:51Z
[SPARK-6980] Minor cleanup and scala style fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
