cloud-fan commented on code in PR #37631: URL: https://github.com/apache/spark/pull/37631#discussion_r953401126
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ########## @@ -527,7 +527,7 @@ case class StringSplit(str: Expression, regex: Expression, limit: Expression) override def second: Expression = regex override def third: Expression = limit - def this(exp: Expression, regex: Expression) = this(exp, regex, Literal(-1)); + def this(exp: Expression, regex: Expression) = this(exp, regex, Literal(0)) Review Comment: ideally 0 and -1 should be no difference according to the function doc. Do you use -1 as a legacy flag? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
