Ngone51 commented on code in PR #36200:
URL: https://github.com/apache/spark/pull/36200#discussion_r953741962


##########
core/src/main/scala/org/apache/spark/deploy/ExternalShuffleService.scala:
##########
@@ -79,7 +80,12 @@ class ExternalShuffleService(sparkConf: SparkConf, 
securityManager: SecurityMana
   /** Create a new shuffle block handler. Factored out for subclasses to 
override. */
   protected def newShuffleBlockHandler(conf: TransportConf): 
ExternalBlockHandler = {
     if (sparkConf.get(config.SHUFFLE_SERVICE_DB_ENABLED) && enabled) {
-      new ExternalBlockHandler(conf, 
findRegisteredExecutorsDBFile(registeredExecutorsDB))
+      val shuffleDBName = sparkConf.get(config.SHUFFLE_SERVICE_DB_BACKEND)
+      val dBBackend = DBBackend.byName(shuffleDBName)
+      logInfo(s"Configured ${config.SHUFFLE_SERVICE_DB_BACKEND.key} as 
$shuffleDBName " +
+        s"and actually used value ${dBBackend.name()} ")

Review Comment:
   It sounds like we may use a different db backend regardless of the user 
configured value in some cases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to