gengliangwang commented on PR #37649: URL: https://github.com/apache/spark/pull/37649#issuecomment-1226225115
Spark's decimal has two methods by design: * changePrecision: update in place for better performance * toPrecision: make a copy and check if changing precision works This change seems to break the design. Also, as mentioned in https://github.com/apache/spark/pull/37620#discussion_r954096295, I think it is better to show the original value string representation in the error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
