HyukjinKwon commented on code in PR #37650:
URL: https://github.com/apache/spark/pull/37650#discussion_r954487181
##########
sql/core/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -1733,6 +1733,19 @@ object functions {
*/
def atan2(yValue: Double, xName: String): Column = atan2(yValue,
Column(xName))
+ /**
+ * @param yValue coordinate on y-axis
+ * @param xValue coordinate on x-axis
+ * @return the <i>theta</i> component of the point
+ * (<i>r</i>, <i>theta</i>)
+ * in polar coordinates that corresponds to the point
+ * (<i>x</i>, <i>y</i>) in Cartesian coordinates,
+ * as if computed by `java.lang.Math.atan2`
+ * @group math_funcs
+ * @since 3.4.0
+ */
+ def atan2(yValue: Double, xValue: Double): Column = atan2(lit(yValue),
lit(xValue))
Review Comment:
I think we should probably fix it in PySpark side instead of fixing it in
Scala side (see the comments on the top at both functions.py and
functions.scala)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
