yangwwei commented on PR #37622: URL: https://github.com/apache/spark/pull/37622#issuecomment-1226822958
@dongjoon-hyun could you please take a look at the updated version? Here are the changes: 1. Used 1.0.0 in the installation example to comply with Spark community requirements 2. Removed the "Work with YuniKorn queues" as that adds complexity to the doc, and for Spark users, that's not something that has to be done 3. Addressed other review comments there is one more thing about our version doc. I have implemented some temp workaround in https://issues.apache.org/jira/browse/YUNIKORN-1293, but YuniKorn community folks made a very good point that the workaround wasn't sustainable. Since now there is only the following links in the doc: - https://yunikorn.apache.org/ - https://yunikorn.apache.org/docs/get_started/core_features I think it should be fine that not bind to a specific version, what do you think? YuniKorn folks also pointed out that there are similar docs like the following already: ``` Volcano feature steps help users to create a Volcano PodGroup and set driver/executor pod annotation to link with this [PodGroup](https://volcano.sh/en/docs/podgroup/). ``` and ``` Volcano defines PodGroup spec using [CRD yaml](https://volcano.sh/en/docs/podgroup/#example). ``` please let me know your thought for this, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
