MaxGekk commented on code in PR #37636:
URL: https://github.com/apache/spark/pull/37636#discussion_r954807344
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/urlExpressions.scala:
##########
@@ -110,7 +110,12 @@ object UrlCodec {
}
def decode(src: UTF8String, enc: UTF8String): UTF8String = {
- UTF8String.fromString(URLDecoder.decode(src.toString, enc.toString))
+ try {
+ UTF8String.fromString(URLDecoder.decode(src.toString, enc.toString))
+ } catch {
+ case e: IllegalArgumentException =>
Review Comment:
According to the doc of `URLDecoder.decode`, it can throw
`UnsupportedEncodingException` too. Should we handle the Java exception too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
