MaxGekk commented on code in PR #37632:
URL: https://github.com/apache/spark/pull/37632#discussion_r954987974
##########
core/src/main/scala/org/apache/spark/SparkException.scala:
##########
@@ -29,7 +29,8 @@ class SparkException(
cause: Throwable,
errorClass: Option[String],
errorSubClass: Option[String],
- messageParameters: Array[String])
+ messageParameters: Array[String],
+ context: Array[QueryContext] = Array.empty)
Review Comment:
Yep.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -2071,9 +2071,14 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase {
cause = null)
}
- def multipleRowSubqueryError(plan: String): Throwable = {
+ def multipleRowSubqueryError(context: SQLQueryContext): Throwable = {
new SparkException(
- errorClass = "MULTI_VALUE_SUBQUERY_ERROR", messageParameters =
Array(plan), cause = null)
+ errorClass = "MULTI_VALUE_SUBQUERY_ERROR",
+ messageParameters = Array.empty,
+ cause = null,
+ context = getQueryContext(context),
+ summary = getSummary(context)
+ )
Review Comment:
minor but in any case, ) should be on the line above, see
https://github.com/databricks/scala-style-guide. For example:
```scala
new Bar(
someVeryLongFieldName, // 2 space indent here
andAnotherVeryLongFieldName,
"this is a string",
3.1415)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
