gengliangwang commented on code in PR #37663:
URL: https://github.com/apache/spark/pull/37663#discussion_r955828342
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:
##########
@@ -698,9 +751,14 @@ trait DivModLike extends BinaryArithmetic {
case class Divide(
left: Expression,
right: Expression,
- failOnError: Boolean = SQLConf.get.ansiEnabled) extends DivModLike {
+ evalMode: EvalMode.Value = EvalMode.fromSQLConf(SQLConf.get)) extends
DivModLike {
+
+ def this(left: Expression, right: Expression) =
+ this(left, right, EvalMode.fromSQLConf(SQLConf.get))
- def this(left: Expression, right: Expression) = this(left, right,
SQLConf.get.ansiEnabled)
+ // `try_divide` has exactly the same behavior as the legacy divide, so here
it only executes
+ // the error code path when `evalMode` is `ANSI`.
+ protected override def failOnError: Boolean = evalMode == EvalMode.ANSI
Review Comment:
Yes, sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
