LuciferYang commented on code in PR #37610: URL: https://github.com/apache/spark/pull/37610#discussion_r955852413
########## common/network-common/src/main/java/org/apache/spark/network/shuffledb/RocksDBIterator.java: ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.network.shuffledb; + +import java.io.IOException; +import java.util.AbstractMap; +import java.util.Map; +import java.util.NoSuchElementException; + +import com.google.common.base.Throwables; +import org.rocksdb.RocksIterator; + +/** + * RocksDB implementation of `DBIterator`. + */ +public class RocksDBIterator implements DBIterator { + + private final RocksIterator it; + + private boolean checkedNext; + + private boolean closed; + + private Map.Entry<byte[], byte[]> next; + + public RocksDBIterator(RocksIterator it) { + this.it = it; + } + + @Override + public boolean hasNext() { + if (!checkedNext && !closed) { + next = loadNext(); + checkedNext = true; + } + if (!closed && next == null) { + try { + close(); + } catch (IOException ioe) { + throw Throwables.propagate(ioe); + } + } + return next != null; + } + + @Override + public Map.Entry<byte[], byte[]> next() { + if (!hasNext()) { + throw new NoSuchElementException(); + } + checkedNext = false; + Map.Entry<byte[], byte[]> ret = next; + next = null; + return ret; + } + + @Override + public void close() throws IOException { + if (!closed) { + it.close(); + closed = true; + next = null; + } + } + + @Override + public void seek(byte[] key) { + it.seek(key); + } + + @Override + public void remove() { Review Comment: will remove this , I found ``` default void remove() { throw new UnsupportedOperationException("remove"); } ``` in java.util.Iterator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
