xinrong-meng commented on code in PR #37635:
URL: https://github.com/apache/spark/pull/37635#discussion_r956438477
##########
python/pyspark/sql/types.py:
##########
@@ -2268,12 +2268,40 @@ def convert(self, obj: "np.generic", gateway_client:
GatewayClient) -> Any:
return obj.item()
+class NumpyArrayConverter:
+ def can_convert(self, obj: Any) -> bool:
+ return has_numpy and isinstance(obj, np.ndarray)
+
+ def convert(self, obj: "np.ndarray", gateway_client: GatewayClient) ->
JavaObject:
+ from pyspark import SparkContext
+
+ gateway = SparkContext._gateway
+ assert gateway is not None
+
+ plist = obj.tolist()
+ # np.array([]).dtype is dtype('float64') so set float for empty plist
+ ptpe = type(plist[0]) if len(plist) > 0 else float
+ tpe_dict = {
+ int: gateway.jvm.int,
Review Comment:
Since `plist = obj.tolist()`, `plist` is a list of Python scalars, see
https://numpy.org/doc/stable/reference/generated/numpy.ndarray.tolist.html.
So `tpe_dict` maps Python types to Java type.
That's consistent with `NumpyArrayConverter.convert` which calls
`obj.item()`, see
https://numpy.org/doc/stable/reference/generated/numpy.ndarray.item.html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
