cloud-fan commented on code in PR #37672:
URL: https://github.com/apache/spark/pull/37672#discussion_r957921008
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1147,7 +1147,7 @@ object CollapseProject extends Rule[LogicalPlan] with
AliasHelper {
/**
* Check if the given expression is cheap that we can inline it.
*/
- private def isCheap(e: Expression): Boolean = e match {
+ def isCheap(e: Expression): Boolean = e match {
Review Comment:
Note that `isCheap` returns true for `PythonUDF`. It's OK for
`CollapseProject` as the python udf planner will deduplicate python udfs in a
single project operator. I'm not sure about multi-like optimization though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
