mridulm commented on code in PR #37638:
URL: https://github.com/apache/spark/pull/37638#discussion_r958962174
##########
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java:
##########
@@ -296,10 +301,15 @@ protected void serviceInit(Configuration externalConf)
throws Exception {
DEFAULT_SPARK_SHUFFLE_SERVICE_METRICS_NAME);
YarnShuffleServiceMetrics serviceMetrics =
new YarnShuffleServiceMetrics(metricsNamespace,
blockHandler.getAllMetrics());
+ YarnShuffleServiceMetrics mergeManagerMetrics =
+ new YarnShuffleServiceMetrics("mergeManagerMetrics",
blockPushResolver.getMetrics());
Review Comment:
We should not be directly creating `RemoteBlockPushResolver` within service
init - it is done via `newMergedShuffleFileManagerInstance`, so that it returns
the right instance configured by admin (by default disabled).
We should be adding a `getMetrics` to `MergedShuffleFileManager` to retrieve
the metrics we want to register.
Something like this in `MergedShuffleFileManager`
```
default MetricSet getMetrics() {
return Collections::emptyMap;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
