mridulm commented on code in PR #37624:
URL: https://github.com/apache/spark/pull/37624#discussion_r959212862
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -809,6 +832,24 @@ public void close() {
}
}
+ /**
+ * Call `shutdownNow` to stop all actively executing tasks and halts the
+ * processing of waiting tasks in `mergedShuffleCleaner`.
+ */
+ private void shutdownMergedShuffleCleanerNow() {
+ try {
+ List<Runnable> unfinishedTasks = mergedShuffleCleaner.shutdownNow();
+ logger.warn("There are still {} tasks not completed in
mergedShuffleCleaner " +
+ "after {} seconds.", unfinishedTasks.size(), cleanerShutdownTimeout);
+ // Wait a while for tasks to respond to being cancelled
+ if (!mergedShuffleCleaner.awaitTermination(cleanerShutdownTimeout,
TimeUnit.SECONDS)) {
+ logger.warn("mergedShuffleCleaner did not terminate");
Review Comment:
nit: `did not terminate in $cleanerShutdownTimeout seconds`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
