vitaliili-db commented on code in PR #37483:
URL: https://github.com/apache/spark/pull/37483#discussion_r959836768
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -2488,11 +2568,10 @@ case class Encode(value: Expression, charset:
Expression)
""",
since = "3.3.0",
group = "string_funcs")
-// scalastyle:on line.size.limit
case class ToBinary(
- expr: Expression,
- format: Option[Expression],
- nullOnInvalidFormat: Boolean = false) extends RuntimeReplaceable
Review Comment:
done.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -2534,7 +2615,7 @@ case class ToBinary(
override def inputTypes: Seq[AbstractDataType] = children.map(_ =>
StringType)
override protected def withNewChildrenInternal(
- newChildren: IndexedSeq[Expression]): Expression = {
Review Comment:
done.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -800,6 +800,19 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase {
s"The '$argName' parameter of function '$funcName' needs to be a
$requiredType literal.")
}
+ def invalidFormatInConversion(
+ argName: String,
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
