srowen commented on code in PR #37338:
URL: https://github.com/apache/spark/pull/37338#discussion_r959864494
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala:
##########
@@ -719,7 +719,7 @@ class CodegenContext extends Logging {
case other if other.isInstanceOf[AtomicType] => s"$c1.compare($c2)"
case udt: UserDefinedType[_] => genComp(udt.sqlType, c1, c2)
case _ =>
- throw
QueryExecutionErrors.cannotGenerateCodeForUncomparableTypeError("compare",
dataType)
+ throw
QueryExecutionErrors.cannotGenerateCodeForIncomparableTypeError("compare",
dataType)
Review Comment:
Don't revert this, but, this is very pedantically techincally incorrect.
"Incomparable" means "without peer, the best". "Uncomparable" isn't a word
really, but, probably more accurate. Whatev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
