cloud-fan commented on code in PR #37741:
URL: https://github.com/apache/spark/pull/37741#discussion_r960209742
##########
project/MimaExcludes.scala:
##########
@@ -118,79 +96,23 @@ object MimaExcludes {
ProblemFilters.exclude[Problem]("org.apache.spark.sql.execution.*"),
ProblemFilters.exclude[Problem]("org.apache.spark.sql.internal.*"),
ProblemFilters.exclude[Problem]("org.apache.spark.sql.errors.*"),
+ // SPARK-40283: add jdbc as default excludes
+ ProblemFilters.exclude[Problem]("org.apache.spark.sql.jdbc.*"),
Review Comment:
We do have developer APIs in this package (e.g. `JdbcDialect`), but dialect
implementations are private (e.g. `private object DB2Dialect extends
JdbcDialect`). I have no idea why mima still checks these dialect
implementations...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
