sunchao commented on code in PR #37749: URL: https://github.com/apache/spark/pull/37749#discussion_r960277773
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/V2ExpressionUtils.scala: ########## @@ -105,18 +105,27 @@ object V2ExpressionUtils extends SQLConfHelper with Logging { TransformExpression(bound, resolvedRefs, Some(numBuckets)) } } - case NamedTransform(name, refs) - if refs.length == 1 && refs.forall(_.isInstanceOf[NamedReference]) => Review Comment: Hmm I remember added this check since storage partitioned join can only handle one named reference in partition transform at the moment. There's an [assertion](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala#L656) in `KeyGroupedShuffleSpec` for this. Could you add a test in `EnsureRequirementsSuite` for a `NamedTransform` with >1 named references? just to make sure it's not breaking anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org