viirya commented on code in PR #37758:
URL: https://github.com/apache/spark/pull/37758#discussion_r961934382
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3523,8 +3525,8 @@ class Analyzer(override val catalogManager:
CatalogManager)
val project = Project(projectList, Join(left, right, joinType,
newCondition, hint))
project.setTagValue(
Project.hiddenOutputTag,
- hiddenList.map(_.markAsSupportsQualifiedStar()) ++
- project.child.metadataOutput.filter(_.supportsQualifiedStar))
+ hiddenList.map(_.markAsQualifiedAccess()) ++
Review Comment:
The new semantics read a bit weird. Previously it is understandable that
`markAsSupportsQualifiedStar` means `hiddenList` can be accessed by qualified
star.
But how to interpret `markAsQualifiedAccess` here? I think in `hiddenList`
it is duplicated join keys. What does it mean to mark them as qualified access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
