itholic commented on code in PR #37786:
URL: https://github.com/apache/spark/pull/37786#discussion_r962518751
##########
python/pyspark/sql/functions.py:
##########
@@ -3925,10 +3987,20 @@ def dayofmonth(col: "ColumnOrName") -> Column:
def dayofyear(col: "ColumnOrName") -> Column:
"""
- Extract the day of the year of a given date as integer.
+ Extract the day of the year of a given date/timestamp as integer.
.. versionadded:: 1.5.0
+ Parameters
+ ----------
+ col : :class:`~pyspark.sql.Column` or str
+ target date/timestamp column to work on.
+
+ Returns
+ -------
+ :class:`~pyspark.sql.Column`
+ day of the year for given date/timestamp as integer.
Review Comment:
Very nit, and don't much have strong feeling about this,
Maybe:
```
`day` of the year for given...
```
since we describe
```
`week` of the year for given...
```
in the `weekofyear` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
