ivoson commented on PR #37268: URL: https://github.com/apache/spark/pull/37268#issuecomment-1237086479
Have been busy for last 2 weeks, get back to this PR. Based on previous discussion, we prefer to remove the `taskOnly` method and create `TaskResourceProfile` implicitly when executor resources are not specified. I made the change in last commit. We'll create the `TaskResourceProfile` implicitly. And the behavior will be: 1. When dynamic allocation is disabled, `TaskResourceProfile` is supported and share executors with default resource profile. 2. When dynamic allocation is enabled, the behavior is the same as before. We just take `TaskResourceProfile` as a special `ResourceProfile` with no custom executor resources requests. In this way, I think we can decouple this PR with the executor re-use work between different RPs. And there should be no conflict with these two works. Gentle ping @tgravescs @Ngone51 . Would you please share your opinion about this and help review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
