kevin85421 commented on PR #37411:
URL: https://github.com/apache/spark/pull/37411#issuecomment-1237801841

   I have revisited the configurations in this PR and updated their default 
values after the discussion with @Ngone51.
   
   (1) initial delay: set initial delay to `executorTimeoutMs` (default: 30s)
   
   ```scala
   override def onStart(): Unit = {
     timeoutCheckingTask = eventLoopThread.scheduleAtFixedRate(
       () => Utils.tryLogNonFatalError { 
Option(self).foreach(_.ask[Boolean](ExpireDeadHosts)) },
       executorTimeoutMs, checkTimeoutIntervalMs, TimeUnit.MILLISECONDS)
   }
   ```
   
   (2) `checkTimeoutIntervalMs`: the thread in (1) will execute the function 
`expireDeadHosts` every  `checkTimeoutIntervalMs` (default: 15s).
   ```scala
   private val checkTimeoutIntervalMs = 
sc.conf.get(Network.NETWORK_TIMEOUT_INTERVAL)
   ```
   
   (3) `executorTimeoutMs`: the default value of 
`STORAGE_BLOCKMANAGER_HEARTBEAT_TIMEOUT` is optional, and thus the default 
value is equal to `NETWORK_EXECUTOR_TIMEOUT` (default: 30s).
   ```scala
   private val executorTimeoutMs = sc.conf.get(
     config.STORAGE_BLOCKMANAGER_HEARTBEAT_TIMEOUT
   ).getOrElse(
     sc.conf.get(Network.NETWORK_EXECUTOR_TIMEOUT)
   )
   ```
   
   (4) `expiryCandidatesTimeout`: if `checkWorkerLastHeartbeat` is true, the 
value will be `HEARTBEAT_EXPIRY_CANDIDATES_TIMEOUT` (default: 90s).
   
   ```scala
   private lazy val expiryCandidatesTimeout = checkWorkerLastHeartbeat match {
     case true =>
       logWarning(s"Worker heartbeat check is enabled. It only works normally 
when" +
         s"${config.HEARTBEAT_EXPIRY_CANDIDATES_TIMEOUT.key} is larger than 
worker's" +
         s"heartbeat interval.")
       sc.conf.get(config.HEARTBEAT_EXPIRY_CANDIDATES_TIMEOUT)
     case false => 0
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to