Yikun commented on code in PR #37802:
URL: https://github.com/apache/spark/pull/37802#discussion_r963695606
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala:
##########
@@ -54,11 +56,33 @@ private[spark] class VolcanoFeatureStep extends
KubernetesDriverCustomFeatureCon
metadata.setName(podGroupName)
metadata.setNamespace(namespace)
pg.setMetadata(metadata)
-
var spec = pg.getSpec
if (spec == null) spec = new PodGroupSpec
+ val queue = kubernetesConf.getOption(POD_GROUP_SPEC_QUEUE)
+ if (queue.isDefined) {
+ spec.setQueue(queue.get)
+ }
+ val minResourceCPU =
kubernetesConf.getOption(POD_GROUP_SPEC_MIN_RESOURCE_CPU)
+ val minResourceMemory =
kubernetesConf.getOption(POD_GROUP_SPEC_MIN_RESOURCE_MEMORY)
+ if (minResourceCPU.isDefined || minResourceMemory.isDefined) {
+ val minResources = new util.HashMap[String, Quantity]
+ if (minResourceCPU.isDefined) {
+ minResources.put("cpu", new Quantity(minResourceCPU.get))
+ }
+ if (minResourceMemory.isDefined) {
+ minResources.put("memory", new Quantity(minResourceMemory.get))
+ }
+ spec.setMinResources(minResources)
Review Comment:
This will force to replace existing MinResources in template and ignore
existing template
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala:
##########
@@ -54,11 +56,33 @@ private[spark] class VolcanoFeatureStep extends
KubernetesDriverCustomFeatureCon
metadata.setName(podGroupName)
metadata.setNamespace(namespace)
pg.setMetadata(metadata)
-
var spec = pg.getSpec
if (spec == null) spec = new PodGroupSpec
+ val queue = kubernetesConf.getOption(POD_GROUP_SPEC_QUEUE)
Review Comment:
```scala
val pg = template.map(client.podGroups.load(_).get).getOrElse(new PodGroup())
val builder = new PodGroupBuilder(pg)
.editOrNewMetadata()
.withName(podGroupName)
.withNamespace(namespace)
.endMetadata()
.editOrNewSpec()
.endSpec()
if (xxx) {
builder.editOrNewSpec().endSpec()
}
return Seq(builder.build())
```
If we decided to add parameters support, the builder style might more stable
and easy to maintainance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
