aokolnychyi commented on code in PR #37749:
URL: https://github.com/apache/spark/pull/37749#discussion_r964020570
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala:
##########
@@ -361,6 +361,18 @@ object KeyGroupedPartitioning {
partitionValues: Seq[InternalRow]): KeyGroupedPartitioning = {
KeyGroupedPartitioning(expressions, partitionValues.size,
Some(partitionValues))
}
+
+ def supportsExpressions(expressions: Seq[Expression]): Boolean = {
+ def isSupportedTransform(transform: TransformExpression): Boolean = {
+ transform.children.size == 1 &&
transform.children.head.isInstanceOf[AttributeReference]
+ }
+
+ expressions.forall {
+ case _: NamedExpression => true
Review Comment:
I was mainly judging from the perspective of `V2ExpressionUtils` but I agree
this is safer. Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
