dongjoon-hyun commented on code in PR #37803:
URL: https://github.com/apache/spark/pull/37803#discussion_r965609555
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStepSuite.scala:
##########
@@ -510,6 +511,20 @@ class BasicExecutorFeatureStepSuite extends SparkFunSuite
with BeforeAndAfter {
assert(mem === s"${expected}Mi")
}
+ test("SPARK-39546: executor pod template should support port definitions") {
+ val baseDriverPod = SparkPod.initialPod()
+ val ports = new ContainerPortBuilder()
+ .withName("port-from-template")
+ .withContainerPort(1000)
+ .build()
+
baseDriverPod.container.setPorts(JavaConverters.seqAsJavaListConverter(Seq(ports)).asJava)
+ val step1 = new BasicExecutorFeatureStep(newExecutorConf(), new
SecurityManager(baseConf),
+ defaultProfile)
+ val podConfigured1 = step1.configurePod(baseDriverPod)
+ // port-from-template should exist after step1
+ assert(podConfigured1.container.getPorts.contains(ports))
+
Review Comment:
Shalll we remove this redundant empty line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
