gengliangwang commented on code in PR #37832:
URL: https://github.com/apache/spark/pull/37832#discussion_r965662647
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -4476,6 +4476,18 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
sql("select * from test_temp_view"),
Row(1, 2, 3, 1, 2, 3, 1, 1))
}
+
+ test("SPARK-40389: Don't eliminate a cast which can cause overflow") {
Review Comment:
The test case requires creating a real table. Otherwise, the rule "constant
folding" will take effect...
In the `sql-tests`, creating a table and dropping it at the end in the
golden file seems heavy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
